New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style consistency #1

Merged
merged 5 commits into from Oct 5, 2014

Conversation

Projects
None yet
2 participants
@nathantypanski
Contributor

nathantypanski commented Oct 4, 2014

Thanks for merging my other PR! I really appreciate the positive feedback.

This just contains code style and consistency changes, most of which are related to the compatibility updates from my previous PR.

None of this is strictly necessary (and nothing here affects runtime), but it makes the codebase ever-so-slightly nicer to work with.

@nathan-hoad

This comment has been minimized.

Owner

nathan-hoad commented Oct 5, 2014

This looks good! I'm going to merge it in, however something I should have made public is that you've motivated me to rewrite the library using CFFI to save the headaches that C extensions create (bytes vs strings, extensibility, documentation, PyPy support, refcounting and so on).

The current branch is available here - I've pushed my work only a few minutes ago, but I believe it mirrors the current API exactly, and updates the Python 3 API to mirror the Python 2 API exactly regarding str vs bytes for dictionary keys by making all keys bytes.

Let me know what you think! It would be good to get more activity on the project. I'm not going to merge it in and release it until I've played with it a little while longer, but in my testing so far it seems pretty good.

nathan-hoad added a commit that referenced this pull request Oct 5, 2014

@nathan-hoad nathan-hoad merged commit 5c882c4 into nathan-hoad:master Oct 5, 2014

@nathantypanski

This comment has been minimized.

Contributor

nathantypanski commented Oct 14, 2014

Hey!

Good job with the CFFI support. I don't have any experience writing code that uses it, but I can see where it is nice to have.

Just to confirm that this was the case, I did at least fetch your branch and use it to scan for wireless networks with Python 3. This was successful. I've been short on time lately, so it's up in the air whether I'll take the time to learn CFFI so I can mess with this further, but it's nice to see an even more portable variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment