Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey out user icons when they leave the room #10

Closed
ghost opened this issue Oct 21, 2015 · 10 comments
Closed

Grey out user icons when they leave the room #10

ghost opened this issue Oct 21, 2015 · 10 comments

Comments

@ghost
Copy link

ghost commented Oct 21, 2015

It would be nice, especially for big rooms, if the icon that displays up to which point a user has read could grey out if they are no longer in the room. Though some users may not want this so it could be an optional feature.

@ByteCommander
Copy link

We could also just summarize this novella above into:

Let the user bubble disappear (preferably nicely animated) when users leave the room, instead of just stopping to update it.

@ghost
Copy link
Author

ghost commented Oct 21, 2015

Perhaps there should be a default, but in there preferences the user should have the option to change to a different appearing and leaving style.

@ByteCommander
Copy link

If the user leaves, the chat itself already shows an animation to let their icons float away from the user list on the right between title/description and the star wall. Too much animation does not look good. The site should still keep some seriousness.

@ghost
Copy link
Author

ghost commented Oct 21, 2015

Well, I don't know then, perhaps it should high-five the other icons with a little hand and then turn into a puff of smoke. ;)

@KazWolfe
Copy link

KazWolfe commented Nov 1, 2015

I think it makes more sense to keep it as-is. The entire reason for this is to see what users have read -- removing the last known location when a user leaves seems rather counterproductive.

@ghost
Copy link
Author

ghost commented Nov 2, 2015

Well some users may want it so perhaps it should be a customizable option that will be off by default (or maybe on, depending on the popularity of the feature that is). But it would be nice, especially for big rooms, if you could tell if that user is still online, at least by greying the icon out slightly even if you keep it where it is.

@nathan-osman
Copy link
Owner

I like the idea of fading the image.

@ghost ghost changed the title Roll the users off when they leave Grey out user icons when they leave the room Nov 2, 2015
@nathan-osman
Copy link
Owner

This has been added with the latest commit - users fade out when they leave and disappear. If they keep the page open but switch tabs, their image is greyed out (it fades to 50% opacity). These changes should show up sometime within the next day or so.

@ByteCommander
Copy link

@nathan-osman I think the greying out of users who are not looking at the chat at the moment is nice, but should be an optional preference to enable.
This affects the user's privacy in a way that might be not wanted, so please add a checkbox in the preferences dialogue for disabling this.

@nathan-osman
Copy link
Owner

Yeah. Good point. I'll add an option for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants