Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use other selectors than id, when initializing Split.js. #15

Closed
gsanta opened this issue Nov 16, 2015 · 5 comments
Closed

Comments

@gsanta
Copy link

gsanta commented Nov 16, 2015

Sorry, again :)

The fact that I have to give element ids, when initializing Split.js seems to be limiting. In many project, using ids are discouraged.
The getElemetById may could be replaced with querySelector, that would accept any kind of selector.

@nathancahill
Copy link
Owner

Yeah, I've been thinking about doing that. It's supported in all browsers that I care about. It would be a new major release though, because it would break backwards compatibility.

@gsanta
Copy link
Author

gsanta commented Nov 16, 2015

Yes, that's right.
But it may would worth it, because the migration path is not difficult. (the user only has to put # in front of the ids)

@gsanta
Copy link
Author

gsanta commented Nov 16, 2015

Until it's resolved, I use a fork.

@nathancahill
Copy link
Owner

Released in 1.0. Thanks!

@gsanta
Copy link
Author

gsanta commented Nov 17, 2015

Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants