Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement pivot_*() functions #101

Merged
merged 2 commits into from Jul 31, 2022
Merged

Conversation

nathaneastwood
Copy link
Owner

@nathaneastwood nathaneastwood commented Jul 31, 2022

Closes #98.

@etiennebacher I made some modifications to the original PR:

  1. I squashed the commits into one.
  2. I fixed some syntax issues.
  3. I removed the tidyr references. I understand the desire to include them and it kind of makes sense, however there would be a couple of issues doing so:
    a. Namespace clashes - as you pointed out.
    b. I would need to keep up with any changes in the tidyr package which, whilst I aspire to do so, I do not have the time for.
  4. Removed any tibble references. poorman isn't designed to work with tibbles.

Re your comment about NSE. Generally I use poorman:::eval_select_pos(). I will look to update this at some point to use it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@af2940e). Click here to learn what that means.
The diff coverage is 82.64%.

@@            Coverage Diff            @@
##             master     #101   +/-   ##
=========================================
  Coverage          ?   93.23%           
=========================================
  Files             ?       56           
  Lines             ?     1374           
  Branches          ?        0           
=========================================
  Hits              ?     1281           
  Misses            ?       93           
  Partials          ?        0           
Impacted Files Coverage Δ
R/pivot_wider.R 77.77% <77.77%> (ø)
R/pivot_longer.R 89.79% <89.79%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2940e...291ace6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants