Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve_method assertion error for state shortcut due to Dictionary in game_states #498

Closed
Selenyhr opened this issue Feb 29, 2024 · 0 comments · Fixed by #501
Closed

resolve_method assertion error for state shortcut due to Dictionary in game_states #498

Selenyhr opened this issue Feb 29, 2024 · 0 comments · Fixed by #501
Assignees
Labels
bug Something isn't working

Comments

@Selenyhr
Copy link
Contributor

Describe the bug
When Dialogue Manager starts up, it adds a Dictionary within the game_states that corresponds to all project Autoloads.

When trying to resolve a method that is available within one of the state shortcuts Autoloads, an assertion error is triggered due to the execution failing on this Dictionary.

Since it will attempt all other state shortcuts afterwards, it will eventually find it, however the assertion failure could be considered annoying.

Affected version

  • Dialogue Manager version: v2.35.0
  • Godot version: v4.2.1.stable

To Reproduce

  • Create a blank project with DialogueManager.
  • Create any sort of Autoload that contains a method we'd like to access within DM:
extends Node


func autoload_test() -> void:
	print("Success!")
  • Call this method within a script, and run this script:
~ start

do autoload_test()

=> END

Expected behavior
No assertion error is raised if the expression fails to run for a single game state. It should however be run if all game states fail to run the expression.

Screenshots
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants