Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker unexpected year focus after shift+tab #119

Closed
maksnester opened this issue Apr 4, 2018 · 3 comments
Closed

DatePicker unexpected year focus after shift+tab #119

maksnester opened this issue Apr 4, 2018 · 3 comments
Assignees
Labels

Comments

@maksnester
Copy link

There is an example: https://jsfiddle.net/rxb83Lb1/

When navigate across inputs with tab button there are some issue with focus.

  1. Select the last input
  2. Shift+Tab (picker input has focus)
  3. Shift+Tab again - now year input receives focus, but expected that first input will get it.

Also if something has been changed on step 2 focus just disappears and after another shift-tab it will be on the first input.

@maksnester
Copy link
Author

Also with tabindex=-1 there are outlines appear for panes.

@nathanreyes nathanreyes self-assigned this Apr 8, 2018
@kl3sk
Copy link

kl3sk commented Apr 9, 2018

As curious as it sounds, in the natural order (eg: left to right) it works perfectly.

@nathanreyes
Copy link
Owner

You have the right approach (setting tabindex=-1). However, the year selector also needs tabindex=-1, which you don't have access to. The next update will use tabindex=-1 as the default for the native popover component, which should take care this issue.

For the outline problem, I don't think it would be wise to just set outline: none in css, as I think there should be some indication of focus. I think I'll just use a thin dotted border or some other sensible styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants