New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong day #50
Comments
Interesting, I'm not able to duplicate. Can you provide the following? Browser: Also, what time zone are you located? I'm wondering if this is a bug when parsing dates into certain time zones. |
Browsers:
OS: Linux (Antergos) I am testing this directly from the example in https://vcalendar.netlify.com/datepicker so I don't have access to the package.json file. Important: This happens only for specific dates, for example in 2018 it works fine, also in 1884 works fine, but in 1968 it fails. |
Do you have vue-devtools installed for Chrome? If so, can you inspect |
I have vue-devtools installed, I will try to test it in a few days.. |
I have seen a similar issue (I think it's the same issue) and it is related to timezones. I instantiate a with a set of strings in the Then in the dateInfo utility it calls |
Ah that is a good catch and may be the culprit. I was basically using |
Im facing the same problem, im in Brazil and here is GMT+3 the data saved in mongodb was in UTC and , in order to solve it i add 3 hours, tnkx @nathanreyes for your suggestion
|
PR open. I'm worried about the impact this will have on anyone who already assumes they are using a local date time. However the |
@jgandt Thanks for the contribution. Before I accept though, I think there is a separate issue here. Before you were entering the date in the ISO8601 YYYY-MM-DD format, which browsers now implicitly parse in UTC instead of your local timezone (for some strange reason). Case in point, if you were to use slashes instead of dashes, I believe your date should parse correctly. Let me do some more investigation though. |
Ok cool. How can we solve this? Is there a different code change I should make? Should I be converting all of my Dates to a local DateTime before passing them into the plugin as @anselmobattisti has basically done? In my testing, I agree that However, if someone passes in a local date time, unexpected things will still happen. Thoughts? |
Looking to get this fixed ASAP. |
@jgandt I think I will parse date strings using a custom parser as to avoid the UTC conversion problem. Then we can re-assess to see what issues are still existing. |
@jgandt Did |
Yup it did! Thanks so much! |
@jonagoldman Ok I know it has been a while. Would just like to confirm to see if you are still experiencing your original bug as of |
@nathanreyes seems fixed now! Thanks! |
Thanks. Closing this, hopefully for good. |
"Closing this, hopefully for good." |
@Byloor agree with you. |
This is taken from the example in https://vcalendar.netlify.com/datepicker.
As you can see the popover says "Sun, Oct 13, 1968" but the calendar shows "Mon, Oct 14, 1968".
This seems to happen only when you go back a few decades, let say to the 60s or 20s...
The text was updated successfully, but these errors were encountered: