New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@media min-width value on ...-responsive.css #17
Comments
I just discovered this as well, I don't think there should be any overlap with the media query widths as it causes odd display issues. My new favourite grid system! |
Can you elaborate on the "odd display issues?" The reason I have it at 767px and not 768px is because the iPad's narrowest is at 768px. So, everything below that is considered to be "mobile." You'll notice that other grid frameworks, such as Zurb Foundation, also use 767px… https://github.com/zurb/foundation/blob/master/scss/foundation/components/_dropdown.scss#L125 |
If you slowly resize the screen when it gets to the break points you have the css from both media queries come into effect. @media screen and (max-width: 767px) { and @media screen and (min-width: 767px) and (max-width: 1025px) { and Skeletons http://www.getskeleton.com/ media queries don't overlap: /* Tablet Portrait size to standard 960 (devices and browsers) */ /* All Mobile Sizes (devices and browser) */ |
Ah, gotcha. So, I'm dumb. Yeah, that needs to be fixed. :) I'll try to get to that today. |
Alrighty, pushed a fix… Thanks for bringing this to my attention. |
Thanks Nathan! |
You're welcome. By the way, if you don't want padding on the grid units, you can do a Sass build with That will keep any |
unsemantic-grid-responsive.css and the like...
@media screen and (min-width: 767px) {
@media screen and (min-width: 768px) {
I believe this bug is there because a tablet grid would fill the gap, however this grid is only for desktop to mobile.
P.S. - Loving the grid so far!
P.P.S. - I read your reasoning behind the default padding on grid-x. I either don't understand it (probably because I haven't used push/pull), or I don't agree. :p
P.P.P.S. - I know this could be said for any grid-x, but I really wish there were (*-)grid-1 - 4.
The text was updated successfully, but these errors were encountered: