New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Behavior of Library? #46
Comments
Hi @royherma. An InputAccessoryView has no knowledge of what lies within a UIViewController and thus cannot adjust the bottom inset automatically. You need to use the delegate method to adjust the bottom inset. Not sure what you mean by laggy. I have never experienced lag using the InputAccessoryView. Sent with GitHawk |
Sure makes sense, but I think it would be extremely valuable to offer an example of how the InputAccessoryView (and ios's .inputAccesoryView properties in general) can be leveraged to correctly adjust content offset and inset of scrollviews/tableviews/etc I'll try to get a video up of laggyness - could be just the simulator but i'll also check on a real device. |
@royherma have you looked at the example source code? I do show this. https://github.com/nathantannar4/InputBarAccessoryView/blob/master/Example/Example/CommonTableViewController.swift Sent with GitHawk |
I've tried all examples - none of them adjust the content offset of the tableview to display the correct row when the keyboard appears (as in Messenger, WhatsApp). Hopefully you understand the functionality I'm talking about, but if not let me know and I'll send video. |
What do you mean by "correct row"? Adjusting the bottom inset **will not ** scroll the scrollview. That's fundamentally how it works in UIKit. You just need to add some logic to scroll to the row you want. Sent with GitHawk |
Thanks for the responsiveness @nathantannar4, I ended up figuring it out on my end. I think this is relatively desired functionality to work alongside accessory input views in this day and age (for chat/message UIs). Would you like me to add an example and make a PR? |
The animation lag seems like a problem, but the functionality I was talking about is more about the demo. I'll close (you can delete this if you'd like) and add the functionality in the PR I create. |
I'm running into a similar issue that I've been trying to debug for the past five hours or so. I'm pretty confident that its my fault (2nd day using Swift!) though, not the library The two issues are related but not precisely the same:
It seems that The solution to this, I think, is manually setting the content inset. The other solution is using KeyboardManager instead of Edit: The solution I ended up going with was copy-pasting |
@royherma did you ever discovered the animation lag reason while using KeyboardManager? I'm experiencing that now and can't pin-point the cause. It's more confusing that if I send the app to background and foreground while the keyboard is open, for a moment the lag stops but as soon as I try to drag again after releasing the lag comes back. |
I might be wrong, and don't want to sham on all the hard work of the library creator and contributors, but it seems that this project is missing some key functionality of the interactive keyboard + custom inputAccessoryView:
I ran the example and I noticed:
Am I missing something here?
Thanks
The text was updated successfully, but these errors were encountered: