Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ng-bootstrap #7

Closed
dskaggs opened this issue Mar 16, 2016 · 10 comments
Closed

Integrate ng-bootstrap #7

dskaggs opened this issue Mar 16, 2016 · 10 comments

Comments

@dskaggs
Copy link

dskaggs commented Mar 16, 2016

As requested, creating a separate ticket to track getting ng-bootstrap implemented in the seed project.

@NathanWalker
Copy link
Owner

Curious to swing @d3viant0ne in here. Josh, you are working on a Material Design integration correct?

I've been trying to make a decision as to whether to integrate MD or Bootstrap into master.
Whichever one did not go to master, I was thinking of having a branch with the other or if someone wanted to keep up with a forked integration into the other. Thinking aloud here.

@x4080
Copy link

x4080 commented Mar 18, 2016

MD is nicer for Android similarities and I want to shout out to @NathanWalker great job man :)

I think I use your card view plugin (pod)

@joshwiens
Copy link
Collaborator

@dskaggs - https://github.com/DeviantJS

I'll be done with an integration example/guide for Material2 shortly & ng2-bootstrap by the end of the day.

Given the advanced seed is based off the original, you should have a clean map to adding the same to the advanced seed.

@dskaggs
Copy link
Author

dskaggs commented Mar 18, 2016

@d3viant0ne Many thanks. I'm traveling at the moment but will definitely take a look early next week.

@NathanWalker
Copy link
Owner

@x4080 Thanks, hopefully the card view plugin is working alright for ya'. There's still some things to fix with it I believe.

@d3viant0ne Thank you for all your efforts on the parent seed!

@joshwiens
Copy link
Collaborator

@dskaggs - For reference, ng2-bootstrap isn't in very good shape as a package. More than a few console errors, broken references / components. I'll keep the example repo up to day as they release new packages, hopefully it stabilizes.

I'm going to take a crack at using vanilla bootstrap4 to see if I can get better results.

@st-clair-clarke
Copy link

I would vote for support of ng2-material. So when the official angular2-mateirial is released the application will not look very much different.

@CharlBest1
Copy link

+1 for ng2-material integration into seed project. This is an awesome project guys!! Thanks a lot :)

@joshwiens
Copy link
Collaborator

ng2-material will eventually be deprecated in favor of angular2-material which means adding it now, just means we have to rip it out later.

The answer here is to simply let the visual component frameworks mature and then run simple guides / example branches on how to integrate them into the advanced seed. Adding one just means that someone else has to rip it out in order to user his or her preferred framework.

@NathanWalker
Copy link
Owner

closing this in favor of this: #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants