Timing-attack-resistant string comparison #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation leaks information about the correct value of the OTP code in the string comparison, since python's string comparison is short-circuiting. This fixes the vulnerability. See http://crypto.stanford.edu/~dabo/papers/ssl-timing.pdf for why this is important even in network applications.
|
👍 |
|
Sorry, I've been terrible at handling this repo, not got much time these days. Thanks for your help - if anybody's interested in helping maintain the project, give me a shout! |
|
Did you mean to merge instead of closing? =) |
|
Ha, yep, that's pretty rude otherwise! |
nathforge
added a commit
that referenced
this pull request
Oct 26, 2014
Timing-attack-resistant string comparison
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation leaks information about the correct value of
the OTP code in the string comparison, since python's string comparison
is short-circuiting. This fixes the vulnerability. See
http://crypto.stanford.edu/~dabo/papers/ssl-timing.pdf for why this is
important even in network applications.