-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Search results not displayed #632
Comments
Are you maybe using Python 3.12 maybe? streamrip is completely defunct with 3.12 here under Windows 10 (with a clean venv), it does not show any result lists, gets segmentation faults etc. Generally this hint "Most bugs fixed" for the 2.0 major version sadly cannot be confirmed at all after testing it since several hours. The amount of bugs/errors/hiccups is really devastating (it was not much better with 1.9.x anyways) and also the poor errorhandling and constant misuse of asserts for errorhandling... Yes. Maybe some old bugs were fixed, but countless new introduced. If it runs it is nice though, and if you can code I would advise to fix it for your needs, that's what I did with 1.9.x too. For this particular thing just put it in a 3.11 venv if 3.12 is the culprit for a quick solution and you will be able to see your results again. This did at least fix the display in my case without any further analyzing the issue. |
thanks for your reply my python version is 3.12.2 ... what 3.11 version should I use ? On python.org, the last stable version is 3.11.8 . should I keep the 2.0.5 version for streamrip ? revert to an older version ? |
I tested it on 3.11.6, there it works. First of all you can use it as a good base to write your own thing for your own needs. If you are not able to code and want an honest answer : If 1.x works for you for the sake of god switch back. I am sitting here since more than 24 hours in total fixing bugs and QOL issues. Alone the logic behind the lastfm playlist matching is ridiculous - i do not use such language normally because it is offensive and therefore useless, but there is no other word for it in that case - and a perfect example that not everyone should write software. The whole thing is just bad and full of bugs (as said asserts misused as error handling constantly, UX is terrible therefore, parameters in functions that are overwritten hardcoded in the function they are actually used, seemingly async problems re max download speed (at least on Windows), seemingly completely untested in general except for plain vanilla cases, hints to options that do not exist (anymore), the list goes on) |
@crankedguy |
@AllKind Won't ever happen, sorry. Because what I did to the code in the meanwhile you can't just put into a PR without investing a considerate amount of time, which I am a) not willing to invest and b) it's not worth it in this case. Reasons are partly in my last message, The software is not well, if it was "sold" as a tech-demo there would be a different light shining on it at least. Also I deleted a lot of the code. |
Following
|
I revert to Python 3.11.6. I use the streamrip V2.0.5 because the Tidal playlist download only works with the ID. So I have a way to get the tracks properly downloaded. |
This has nothing to do with an URL, this has to do with the python version/an external library in this case. |
This is what I get when I execute : rip search tidal album "john surman" I got the list of all albums from this artist. Then, I am able to download after selection. So it is correct for me. The "rip search playlist" found no playlsit in my personal playlists. It could be because the search doesn't look in my favorites. For the base URL, note that I found that the M Herger Tidal plugin used this base API : 'https://api.tidal.com/v1' instead of "https://api.tidalhifi.com/v1". |
Describe the bug
When using the "rip search" function, either with album name or playlist name, there is nothing displayed.
When using the "rip id" function with corresponding identification, the tracks are correctly downloaded.
Command Used
Debug Traceback
Config File
Operating System
Windows 10
streamrip version
2.0.5
Screenshots and recordings
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: