Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests - Updated #16

Closed
guyzk opened this issue Jan 14, 2020 · 5 comments
Closed

Feature requests - Updated #16

guyzk opened this issue Jan 14, 2020 · 5 comments

Comments

@guyzk
Copy link
Contributor

guyzk commented Jan 14, 2020

  • Other than initial ISO which is already implemented it would be nice to have the option to restrict to one country (select box disabled and set to the requested country code) while still having the phone number validation.

  • Have the option to restrict to specific phone types (mobile, land line, etc).

  • RTL layout support (Mainly the fact that the phone number cannot be RTL event though the entire layout is RTL the phone number itself (and the phone country code) should be in LTR
    e.g. currently in RTL the country code is 1+ instead of +1

  • When using InternationalPhoneNumberInput.withCustomDecoration you cannot change the error text manually and the is no errorMessage in the constructor. Please allow to modify the error message in this factory as well

  • Will it be possible to add the country names to the select box and maybe event provide a list of translations by the iso2 code?

  • Add a search input to easily select a country instead of scrolling through the whole list.

Thanks!

@guyzk
Copy link
Contributor Author

guyzk commented Jan 15, 2020

Other than initial ISO which is already implemented it would be nice to have the option to restrict to one country (select box disabled and set to the requested country code) while still having the phone number validation.

My Bad - Can be done with custom country list

RTL layout support (Mainly the fact that the phone number cannot be RTL event though the entire layout is RTL the phone number itself (and the phone country code) should be in LTR
e.g. currently in RTL the country code is 1+ instead of +1

Can be fixed by adding "textDirection: TextDirection.ltr" to the following lines in widget file:
Row 293: In the Row widget
Row 313: In the TextFormFieldWidget
Row 379: In the select item Row widget
Row 390: In the select item Text widget
Tested: This forces the widget to align correctly even for RTL languages

@guyzk guyzk changed the title Feature request: One country mode and number type Feature request: One country mode and number type - Updated Jan 15, 2020
@guyzk guyzk changed the title Feature request: One country mode and number type - Updated Feature requests - Updated Jan 15, 2020
@guyzk
Copy link
Contributor Author

guyzk commented Jan 16, 2020

@natintosh I can issue a pull request for most of these features and more.
Do you prefer a pull request for each feature or one for all of them?

@natintosh
Copy link
Owner

Sure 🤗

@guyzk
Copy link
Contributor Author

guyzk commented Jan 16, 2020

Done #17
Regarding the translations I might be able to add 2 languages as a start
The rest can be done as pull requests from the community
Happy to help

@natintosh
Copy link
Owner

Hi @guyzk thanks for your contributions then I added the draggable scrollable sheet to the modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants