Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dlibphonenumber #431

Open
sashkent3 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #432
Open

Migrate to dlibphonenumber #431

sashkent3 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #432

Comments

@sashkent3
Copy link

Is your feature request related to a problem? Please describe.
intl_phone_number_input doesn't support Linux, macOS, Windows and WASM platforms because of dependency on libphonenumber_plugin. I propose to instead migrate this package to dlibphonenumber - a Dart port of Google's libphonenumber library.

Describe the solution you'd like
Remove dependency on libphonenumber_plugin, replace all relevant code with dlibphonenumber's implementation.

Describe alternatives you've considered
Updating libphonenumber_plugin to support all relevant platforms seems to me like a lot more complex solution. Dependency on the JS version of libphonenumber is most concerning in the context of WASM.

Additional context
The migration is extremely straightforward.

@sashkent3 sashkent3 linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant