Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check metadata for storage type #62

Closed
RobLBaker opened this issue Feb 22, 2023 · 2 comments · Fixed by #69
Closed

check metadata for storage type #62

RobLBaker opened this issue Feb 22, 2023 · 2 comments · Fixed by #69
Assignees
Labels
enhancement New feature or request

Comments

@RobLBaker
Copy link
Member

eml/dataset/dataTable/attributeList/attribute/storageType

-Error if empty/missing
-Do anything else with this? More tests?

@RobLBaker RobLBaker added the enhancement New feature or request label Feb 22, 2023
@RobLBaker RobLBaker added this to the DPchecker round 3 tests milestone Feb 22, 2023
@RobLBaker RobLBaker self-assigned this Feb 22, 2023
@RobLBaker
Copy link
Member Author

See comments on issue #61 - the same logic applies.

@RobLBaker
Copy link
Member Author

'test_storate_type()':
-Checks to see if there are the same number of attributes (attributeName) and storageTypes
-Does NOT attempt to verify if the number of storageType elements matches the number of columns in the data package data files (for that functionality, use test_fields_match())
-Does verify that the storageType is valid; i.e. is a member of an accepted list of possible storage types. Currently: string, float, date, factor, or characters. I checked several EML files from EMLassemblyline and ezEML; they only had string, float, or date for storageTypes, but the code for EAL makes it look like factor and character are also valid storageTypes. Valid is based just on ezEML/EAL output: any string in storageType is schema-valid.
-Does NOT attempt to verify that the value in storageType logically matches the type data in the corresponding column.

@RobLBaker RobLBaker linked a pull request Mar 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant