Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductFlavours missing for Android #38

Closed
hypery2k opened this issue May 14, 2018 · 3 comments
Closed

ProductFlavours missing for Android #38

hypery2k opened this issue May 14, 2018 · 3 comments

Comments

@hypery2k
Copy link
Contributor

The code in include.gradle does not define any productFlavour, as needed:

https://github.com/bradmartin/nativescript-drawingpad/blob/824cc43b45bb7dda6d0b873bab9b643e2db0690a/src/platforms/android/include.gradle#L2-L4

@bradmartin
Copy link
Member

for NS 4x you shouldn't need that anymore for the build, are you having issues with NS4x or 3x, if less than 4x use the previous with the productFlavor I suppose, we can document this on the README. I've done that on a few other plugins and it seems to work fine.

@bradmartin
Copy link
Member

Which is what this new cmd for 4x does more or less - https://github.com/bradmartin/nativescript-drawingpad/blob/master/src/scripts/build-native.js#L16

@hypery2k
Copy link
Contributor Author

ok, thanks for the hint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants