Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs ios): selector and ripple color css #287

Conversation

Logikgate
Copy link
Contributor

The highlight-color and ripple-color css props for MDTabStrip were not working on iOS, they do now.

MDTabStrip {
    highlight-color: #ffff00; //yellow
    ripple-color: #ff0000; //red
}

Before with the above css:
before

After with the above css:
after

@Logikgate Logikgate force-pushed the fix-ios-tabs-selector-ripple branch from 8a6d463 to 09fbf28 Compare April 29, 2021 00:22
@Logikgate Logikgate force-pushed the fix-ios-tabs-selector-ripple branch from 09fbf28 to b6b0125 Compare April 29, 2021 00:22
@farfromrefug
Copy link
Member

@Logikgate very very nice!

@farfromrefug farfromrefug merged commit 5319ae9 into nativescript-community:master Apr 29, 2021
@Logikgate
Copy link
Contributor Author

@farfromrefug when you have a free moment could we get a new release? 😄

@farfromrefug
Copy link
Member

@Logikgate sorry will do. BTW would you like to join @nativescript-community ? I could give you the release rights.

@Logikgate
Copy link
Contributor Author

Thank you! And yes I would love to join, this is a great set of plugins and I'd be happy to help out more 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants