Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<page> works; <Page> doesn’t #36

Closed
tjvantoll opened this issue Aug 1, 2017 · 4 comments · Fixed by #37
Closed

<page> works; <Page> doesn’t #36

tjvantoll opened this issue Aug 1, 2017 · 4 comments · Fixed by #37

Comments

@tjvantoll
Copy link
Contributor

tjvantoll commented Aug 1, 2017

I was testing out @EddyVerbruggen’s changes that add ActionBar support, which work great btw, and I noticed one small thing.

This works: (<page>)

const Vue = require("nativescript-vue");

new Vue({
  template: `
    <page>
      <ActionBar title="❤️ Vue ❤️"></ActionBar>
      <StackLayout></StackLayout>
    </page>
  `
}).$start();

This doesn’t: (<Page>)

const Vue = require("nativescript-vue");

new Vue({
  template: `
    <Page>
      <ActionBar title="❤️ Vue ❤️"></ActionBar>
      <StackLayout></StackLayout>
    </Page>
  `
}).$start();

In NativeScript we support both so both should work here. Personally I prefer uppercase tag names. Not sure if this is related to the ActionBar commit or not.

@rigor789
Copy link
Member

rigor789 commented Aug 1, 2017

Yep, that's related to my change to ActionBar. I will fix this today when i get a chance.

@tjvantoll
Copy link
Contributor Author

@rigor789 No worries. Also, my app keeps crashing on Android with the latest code from master. Just an fyi.

@EddyVerbruggen
Copy link
Contributor

@rigor789 Allow me to fix that as I need to commit an enhancement to the ActionBar code anyway. #piggyback

@rigor789
Copy link
Member

rigor789 commented Aug 1, 2017

Sure, feel free to fix it.

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants