Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text-node support #7

Closed
rigor789 opened this issue Apr 21, 2017 · 1 comment
Closed

Improve text-node support #7

rigor789 opened this issue Apr 21, 2017 · 1 comment

Comments

@rigor789
Copy link
Member

Consider this example:

<label>Some Text</label>

Some Text is a text-node, which can't be added as a child element in {N}, so we replace the parent element. This works fine for labels, but due to the current implementation, this has undesired side effects:

<button>Some Text</button>

gets rendered as a Label.

The lines to blame are here:
https://github.com/rigor789/nativescript-vue/blob/311c5026aec3452f9cdf11e567d3ad3b1d59227f/nativescript-vue/platform/nativescript/renderer/NativeScriptRenderer.js#L56-L59

@rigor789
Copy link
Member Author

This has been fixed in 8da45a1

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant