Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

RFC: Change how externals are handled #16

Closed
rigor789 opened this issue Mar 13, 2018 · 2 comments
Closed

RFC: Change how externals are handled #16

rigor789 opened this issue Mar 13, 2018 · 2 comments
Labels
RFC Request For Comments - Please leave feedback related to this issue.

Comments

@rigor789
Copy link
Member

Reference: #12 (comment)

My proposal is to mark all dependencies as external. This would mean that in order to make a dependecy bundled (not external) it would have to be moved to devDependencies.

This approach should work for most people, and we can document it in a Optimizations section, where we describe what an external dependency is, how to make something external etc.

I'm open for suggestions, so please leave any feedback here.
@rigor789 rigor789 added the RFC Request For Comments - Please leave feedback related to this issue. label Mar 13, 2018
@lewebsimple
Copy link
Contributor

We could move this to lewebsimple/nativescript-vue-externals

@rigor789 rigor789 mentioned this issue Mar 22, 2018
Closed
@rigor789
Copy link
Member Author

This issue was moved to nativescript-vue/nativescript-vue-externals#2

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
RFC Request For Comments - Please leave feedback related to this issue.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rigor789 @lewebsimple