Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): iOS nested FieldValues not serialized in update() #139

Merged

Conversation

delaneyb
Copy link
Contributor

@delaneyb delaneyb commented Oct 7, 2022

This PR resolves the following issue:

Performing an update with a FIeldValue used as a nested property value such as:

await firebase.firestore().doc('test/1234').update({
    a: {
        b: FieldValue.serverTimestamp()
    }
})

Results in the following firestore document contents:
image

@cla-bot
Copy link

cla-bot bot commented Oct 7, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @delaneyb.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@delaneyb
Copy link
Contributor Author

delaneyb commented Oct 7, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 7, 2022
@cla-bot
Copy link

cla-bot bot commented Oct 7, 2022

The cla-bot has been summoned, and re-checked this pull request!

@triniwiz triniwiz merged commit 7f6da0b into NativeScript:main Oct 12, 2022
@delaneyb delaneyb deleted the fix-ios-update-nested-fieldvalue branch November 3, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants