Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[question] Do the modular plugins support external push provider #7

Closed
PeterStaev opened this issue Oct 19, 2021 · 3 comments · Fixed by #100
Closed

[question] Do the modular plugins support external push provider #7

PeterStaev opened this issue Oct 19, 2021 · 3 comments · Fixed by #100
Labels
enhancement New feature or request

Comments

@PeterStaev
Copy link

The NS Push Notifications plugin was deprecated a while ago in favor of FB and Eddy added nice support for external (non-firebase) push providers: https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/master/docs/NON_FIREBASE_MESSAGING.md . I don't see the any notes in the messaging plugin if such support exists? Or may be there will be a separate plugin for users not using firebase cloud messaging?
@triniwiz triniwiz added the enhancement New feature or request label Oct 20, 2021
@triniwiz
Copy link
Member

This may have slipped me but I'll look at adding it

@lambourn
Copy link
Contributor

lambourn commented Feb 1, 2022

@triniwiz any update on this?

@lambourn lambourn mentioned this issue Feb 2, 2022
Open
@Mridul-DPA
Copy link

@triniwiz we had the same issue and it would be great if you can take your time to have look. :)

triniwiz added a commit that referenced this issue Jul 19, 2022
@triniwiz
feat: support external push provider
a53d5a9 
closes #7
@triniwiz triniwiz mentioned this issue Jul 19, 2022
Merged
triniwiz added a commit that referenced this issue Jul 20, 2022
@triniwiz
feat: support external push provider (#100)
4a04a39 
* feat: support external push provider

closes #7

* fix(messaging): use new requestPermission & permission check for API 33+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support external push provider NativeScript/firebase
4 participants
@triniwiz @PeterStaev @lambourn @Mridul-DPA