Skip to content

Commit

Permalink
fix(angular): remove @angular/http dependency from blueprints for A…
Browse files Browse the repository at this point in the history
…ngular 9 … (#280)
  • Loading branch information
d-koppenhagen committed Jun 27, 2020
1 parent 7faedd6 commit b5678dd
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
"lint": "tslint --project ./tsconfig.json -c ./tslint.json 'src/**/*.ts'",
"lint:fix": "tslint --project ./tsconfig.json -c ./tslint.json 'src/**/*.ts' --fix"
},
"ng-add": {
"save": "devDependencies"
},
"ng-new": {
"save": "devDependencies"
},
"schematics": "./src/collection.json",
"dependencies": {
"@angular-devkit/core": "~9.1.0",
Expand Down
1 change: 0 additions & 1 deletion src/add-ns/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ const addDependencies = () => (tree: Tree, context: SchematicContext) => {

const devDepsToAdd = {
'nativescript-dev-webpack': '~1.5.0',
'@nativescript/schematics': '~2.0.0',
'@nativescript/tslint-rules': '~0.0.5',
};
packageJson.devDependencies = {...devDepsToAdd, ...packageJson.devDependencies};
Expand Down
1 change: 0 additions & 1 deletion src/add-ns/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ describe('Add {N} schematic', () => {
expect(dependencies['reflect-metadata']).toBeDefined();

expect(devDependencies['nativescript-dev-webpack']).toBeDefined();
expect(devDependencies['@nativescript/schematics']).toBeDefined();
expect(devDependencies['@nativescript/tslint-rules']).toBeDefined();
});

Expand Down
4 changes: 1 addition & 3 deletions src/ng-new/application/_files/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"@angular/compiler": "~9.1.0",
"@angular/core": "~9.1.0",
"@angular/forms": "~9.1.0",
"@angular/http": "~9.1.0",
"@angular/platform-browser": "~9.1.0",
"@angular/platform-browser-dynamic": "~9.1.0",
"@angular/router": "~9.1.0",
Expand All @@ -26,8 +25,7 @@
"devDependencies": {
"@angular/cli": "~9.1.0",
"@angular/compiler-cli": "~9.1.0",
"@angular-devkit/core": "~9.1.0",
"@nativescript/schematics": "~2.0.0",<% if(webpack) { %>
"@angular-devkit/core": "~9.1.0",<% if(webpack) { %>
"nativescript-dev-webpack": "~1.5.0",
"@ngtools/webpack": "~9.1.0",
<% } %>"typescript": "~3.8.3"
Expand Down
2 changes: 0 additions & 2 deletions src/ng-new/shared/_files/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@angular/compiler": "~9.1.0",
"@angular/core": "~9.1.0",
"@angular/forms": "~9.1.0",
"@angular/http": "~9.1.0",
"@angular/platform-browser": "~9.1.0",
"@angular/platform-browser-dynamic": "~9.1.0",
"@angular/router": "~9.1.0",
Expand All @@ -40,7 +39,6 @@
"@angular/cli": "~9.1.0",
"@angular/compiler-cli": "~9.1.0",
"@angular-devkit/build-angular": "~0.901.0",
"@nativescript/schematics": "~2.0.0",
"@nativescript/tslint-rules": "~0.0.5",
"@types/jasmine": "~3.5.0",
"@types/jasminewd2": "~2.0.3",
Expand Down

0 comments on commit b5678dd

Please sign in to comment.