Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching out argparse for click (?) #1

Closed
eschanet opened this issue Aug 21, 2021 · 1 comment
Closed

Switching out argparse for click (?) #1

eschanet opened this issue Aug 21, 2021 · 1 comment

Comments

@eschanet
Copy link

Hi!

I stumbled across this project by accident and think it's a really cool approach! Huge props!

While looking at the code, I noticed that you're using argparse to create the CLI. Any specific reason for choosing argparse over something like click (based on optparse)? I am personally not a huge fan of argparse because it can sometimes lead to unexpected behaviour due to it's automagic differentiation between arguments and options. I also think that a proper CLI built with click leads to much more readable code (although I agree that this might be a bit subjective, but here is a simple example).

If you welcome contributions from others on this, I would be down to cleaning up your entrypoint a bit and introduce a proper CLI for this awesome tool. As always, feel free to close this issue in case this is not something you want to change!

Cheers,
Eric

@eschanet eschanet changed the title Switching out argparse for click Switching out argparse for click (?) Aug 21, 2021
@Schneipi
Copy link
Collaborator

Hi Eric,

Thanks for your nice feedback and suggestion!

So far argparse has served us rather well as an entrypoint, by doing what it is supposed to. We tried to emphasize readability by grouping all actions in subparsers.py. Also click would add yet another dependency to the project. We will stick to argparse for the time being. Thanks again for your input. Any other suggestions are of course welcome.

Best regards,
Pit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants