Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compiling MinGW issue - case sensitivity #10

Closed
norru opened this issue Oct 23, 2018 · 0 comments
Closed

Cross-compiling MinGW issue - case sensitivity #10

norru opened this issue Oct 23, 2018 · 0 comments

Comments

@norru
Copy link

norru commented Oct 23, 2018

I am cross-compiling openfx-opencv plugins for Windows from Linux and I've found two minor case sensitivity issues when building openfx as a dependency.

  1. In Support/include/ofxsHWNDInteract.h

#include <Windows.h> should be

#include <windows.h>

as the MinGW header is all lowercase.

  1. in Support/Library/ofxsSupportPrivate.h

#include "ofxsHWndInteract.h" should be

#include "ofxsHWNDInteract.h"

The fixes are trivial if done manually but cause problems when automating the build/reproducing the build (as they require either a source tweak or a toolchain tweak).

devernay added a commit that referenced this issue Oct 23, 2018
devernay added a commit that referenced this issue Jun 14, 2020
devernay added a commit that referenced this issue Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant