Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable reconnecting buffer #138

Closed
avlasor opened this issue Nov 10, 2017 · 3 comments
Closed

Allow to disable reconnecting buffer #138

avlasor opened this issue Nov 10, 2017 · 3 comments

Comments

@avlasor
Copy link

avlasor commented Nov 10, 2017

Hi!
I would like to propose to allow the disabling of reconnecting buffer. Currently in Go client it can be done setting the buffer size with -1 but for java client it is not possible. If we set buffer size to -1 or 0, the default value for buffer is taken. Moreover if a small size is configured (for example 1), the first message is always buffered and resend when client is reconnect. I was asking about it in the google group (https://groups.google.com/forum/#!topic/natsio/UZJmWqpSc9E).

Would it be possible to implement this behavior? I think that it would be useful in cases in which the messages are in real time and an old message could produce to get wrong information.

Regards
Rosalva

@sasbury
Copy link
Contributor

sasbury commented Jul 3, 2018

We are working on a new version of the client that should resolve this issue, I am leaving the issue open for now, but if you are interested in this feature please try the new library in the version2 branch. Feedback is appreciated.

@avlasor
Copy link
Author

avlasor commented Jul 5, 2018

Hi!I am on holidays. As soon as I start to work I'll try it. Thank you very much

@sasbury
Copy link
Contributor

sasbury commented Jul 17, 2018

Released 2.0.0, you can now use -1 to get this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants