Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reconnecting, ignorred IO errors can lead to silently broken connection #150

Closed
edam opened this issue Feb 15, 2018 · 3 comments
Closed

Comments

@edam
Copy link

edam commented Feb 15, 2018

IOExceptions thrown as a result of writing to the OutputStream during a reconnect, whilst trying to write subscription (and pending) commands are currently silently ignored. This could lead to the scenario where the library believes it has successfully recovered a connection, but where some subscriptions have not been re-established.

This scenario may also be especially likely, given that the reconnection code may run where there are networking issues/partitions . At this time, conceivably, a backlog of pending RPC-like requests (i.e., publishes that require a response via a one-shot inbox) may have accumulated, leading to an excess of subscriptions to re-establish.

@edam
Copy link
Author

edam commented Feb 15, 2018

#149

@sasbury
Copy link
Contributor

sasbury commented Jul 3, 2018

We are working on a new version of the client that should resolve this issue, I am leaving the issue open for now, but if you are interested in this feature please try the new library in the version2 branch. Feedback is appreciated.

@sasbury
Copy link
Contributor

sasbury commented Jul 17, 2018

I spent a lot of time on trying to make sure closed is closed, and reconnect is reconnect. Please take a look at 2.0 and reopen this if you are still seeing an issue.

@sasbury sasbury closed this as completed Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants