Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionFactory's JavaDoc: provide the list of keys that can be used on the properties. #25

Closed
laugimethods opened this issue Jun 9, 2016 · 2 comments

Comments

@laugimethods
Copy link

laugimethods commented Jun 9, 2016

The connectionFactory is defined by a Properties object, which should be fill with values defined by a defined set of Keys.
Those keys can be inferred from the actual source code ConnectionFactory.java, but are not listed on the generated ConnectionFactory API...

@mcqueary
Copy link

mcqueary commented Sep 7, 2016

Isn't this what you're looking for (hint: go to javadoc for io.nats.client.Constants and in any property, click Constant Field Values?
http://static.javadoc.io/io.nats/jnats/0.5.3/constant-values.html#io.nats.client.Constants.PROP_CLOSED_CB

EDIT: I will say, in retrospect, those property name constants should be on ConnectionFactory. I'll open an issue.

@sasbury
Copy link
Contributor

sasbury commented Jul 17, 2018

ConnectionFactory was removed, but the Options properties are all javadoc'd in version 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants