Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ReplyTo on NatsJSMsg #314

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Expose ReplyTo on NatsJSMsg #314

merged 1 commit into from
Jan 8, 2024

Conversation

rickdotnet
Copy link
Collaborator

This PR addresses #312 , exposing the ReplyTo property on NatsJSMsg.

@rickdotnet rickdotnet changed the title This is to have parity with other clients Expose ReplyTo on NatsJSMsg Jan 6, 2024
@mtmk mtmk linked an issue Jan 7, 2024 that may be closed by this pull request
Consider Exposing ReplyTo for NatsJSMsg #312
Closed
mtmk
mtmk approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @rickdotnet

@mtmk mtmk merged commit a3f4df6 into nats-io:main Jan 8, 2024
9 checks passed
mtmk added a commit that referenced this pull request Jan 11, 2024
@mtmk
Release 2.1.0-preview.1
7bbdfa8 
* Use System.IO.Pipelines for sending (#303)
* Suggested fixes to interfaces (#297)
* JS Message reply-to exposed (#314)
@mtmk mtmk mentioned this pull request Jan 11, 2024
Merged
mtmk added a commit that referenced this pull request Jan 11, 2024
@mtmk
Release 2.1.0-preview.1 (#326)
cfd01c3 
* Use System.IO.Pipelines for sending (#303)
* Suggested fixes to interfaces (#297)
* JS Message reply-to exposed (#314)
@rickdotnet rickdotnet deleted the js-msg-reply-to branch January 14, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Exposing ReplyTo for NatsJSMsg
2 participants
@rickdotnet @mtmk