Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nats-py[nkeys] won't install on Python 3.12.0 #509

Closed
esjolander opened this issue Oct 17, 2023 · 8 comments
Closed

nats-py[nkeys] won't install on Python 3.12.0 #509

esjolander opened this issue Oct 17, 2023 · 8 comments
Labels
defect Suspected defect such as a bug or regression

Comments

@esjolander
Copy link

esjolander commented Oct 17, 2023

Observed behavior

nats-py[nkeys] has a dependency on ed25519, which errors on install:

AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

This is because ed25519 uses versioneer, which has a bug. There is an issue against ed25519, but it seems to be a dead project.
The right fix might be to move to pynacl, which does install on Python 3.12.

Expected behavior

It should be possible to pull in nkeys on Python 3.12.

Server and client version

Server and client versions don't matter.
I tested the latest nats-py release: pip install 'nats-py[nkeys]==2.4.0'

Host environment

Ubuntu 22.04, x86-64, pyenv used for Python 3.12.

Steps to reproduce

Install Python 3.12.0, then install nats-py[nkeys]

$ python3 --version
Python 3.12.0
$ pip install 'nats-py[nkeys]==2.4.0'
@esjolander esjolander added the defect Suspected defect such as a bug or regression label Oct 17, 2023
@esjolander esjolander changed the title nats-py[nkeys] won't install on Python 12 nats-py[nkeys] won't install on Python 3.12.0 Oct 17, 2023
@itssimon
Copy link

This is a showstopper that needs urgent attention IMO

@wallyqs
Copy link
Member

wallyqs commented Jan 25, 2024

yes, there will be a new release of nkeys with the replaced dependency this week

@RangeMachine
Copy link

Any update on this?

@strangemonad
Copy link

@wallyqs This seems related to this other issue I filed in the nkeys repo nats-io/nkeys.py#10. If I force nkeys to point to the main branch of the git repo instead of pypi then this works (since it installs pynacl)

@itssimon
Copy link

itssimon commented Mar 20, 2024

Hey @wallyqs, it's been a few weeks since you promised the new release of nkeys. Can the community help in any way to make this happen soon?

@philpennock
Copy link
Member

philpennock commented Mar 28, 2024

Someone raised this on Slack and I took a look.

So it looks like what has happened here is that we have [edit: in the https://github.com/nats-io/nkeys.py repo] both a master branch and a main branch, and main has switched to pynacl (thereby fixing this issue), but master has not, and master is still the default branch.

We're chasing this now.

@itssimon
Copy link

Looks like main is now the default branch in the nkeys.py repo, but to fix this issue we'd also need a release to PyPI.

@wallyqs
Copy link
Member

wallyqs commented May 18, 2024

nkeys version with pynacl support has been released today: https://github.com/nats-io/nkeys.py/releases/tag/v0.2.0

@wallyqs wallyqs closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

No branches or pull requests

6 participants