Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendCommand instead of send_command #1

Merged
merged 1 commit into from Feb 25, 2012
Merged

sendCommand instead of send_command #1

merged 1 commit into from Feb 25, 2012

Conversation

JeanSebTr
Copy link
Contributor

This replace the this keyword for the client var inside of a callback and use the right name for the sendCommand method.

I didn't know if I should have updated the version number.

@derekcollison
Copy link
Member

Thanks, I will take a closer look tomorrow and I have some other changes/fixes, so will up the version number and push to npm as well.

Thanks..

derekcollison added a commit that referenced this pull request Feb 25, 2012
@derekcollison
Merge pull request #1 from JeanSebTr/44cad9ee71f5262b6b2bc9e925fa9fb2…
3c036d7 
…20e94f4b

sendCommand instead of send_command
@derekcollison derekcollison merged commit 3c036d7 into nats-io:master Feb 25, 2012
@derekcollison
Copy link
Member

I just pushed 0.2.6 to npm, has your change and a few cleanup items from jshint. Thanks again..

diogogmt added a commit to diogogmt/node-nats that referenced this pull request Feb 2, 2016
@diogogmt
To wrap the grunt work involved in encoding and decoding JSON message…
1a1b7f9 
…s a new attribute has been added to the client options named json.

Unit tests have also been provided.

Addressed review comments:

nats-io#1 - Validate message payload when JSON switch is turned on before publishing
nats-io#2 - Defaults to utf8 or encoding type set by the user
@Amansg4 Amansg4 mentioned this pull request Feb 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeanSebTr @derekcollison