Skip to content

Commit

Permalink
Lock EM to 0.12.10
Browse files Browse the repository at this point in the history
  • Loading branch information
derekcollison committed Sep 17, 2012
1 parent 331a5b3 commit ac8bcd9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions Gemfile
@@ -1,6 +1,6 @@
source "http://rubygems.org"

gem 'eventmachine', '>= 0.12.10'
gem 'eventmachine', '= 0.12.10'
gem 'daemons', '>= 1.1.5'
gem 'json_pure', '>= 1.7.3', :require => 'json'
gem 'thin', '>= 1.4.1'
Expand All @@ -10,4 +10,3 @@ group :test do
gem 'rspec', '>= 2.11.0'
gem 'nats', :path => '.'
end

4 changes: 2 additions & 2 deletions Gemfile.lock
Expand Up @@ -3,7 +3,7 @@ PATH
specs:
nats (0.4.26)
daemons (>= 1.1.5)
eventmachine (>= 0.12.10)
eventmachine (= 0.12.10)
json_pure (>= 1.7.3)
thin (>= 1.4.1)

Expand Down Expand Up @@ -36,7 +36,7 @@ PLATFORMS

DEPENDENCIES
daemons (>= 1.1.5)
eventmachine (>= 0.12.10)
eventmachine (= 0.12.10)
json_pure (>= 1.7.3)
nats!
rake
Expand Down
2 changes: 1 addition & 1 deletion nats.gemspec
Expand Up @@ -16,7 +16,7 @@ spec = Gem::Specification.new do |s|
s.authors = ['Derek Collison']
s.email = ['derek.collison@gmail.com']

s.add_dependency('eventmachine', '>= 0.12.10')
s.add_dependency('eventmachine', '= 0.12.10')
s.add_dependency('json_pure', '>= 1.7.3')
s.add_dependency('daemons', '>= 1.1.5')
s.add_dependency('thin', '>= 1.4.1')
Expand Down

4 comments on commit ac8bcd9

@d
Copy link

@d d commented on ac8bcd9 Apr 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have a problem with EM greater than 0.12.10? Can we test that?

  • Jesse and Phan

@derekcollison
Copy link
Member Author

@derekcollison derekcollison commented on ac8bcd9 Apr 5, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acadiant
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tried implementing some asynchronous HTTP routines using em-http-request's EventMachine::HttpRequest, because the regular Net::HTTP is synchronous-only. I've run into a version conflict though because the em-http-request gem requires eventmachine >= 1.0.0, but NATS doesn't pass its tests on 1.0.0. So before I go off hacking my NATS gem or taking undue risk with versions, I wonder if there's any update. eventmachine is now up to 1.0.3; or has anyone come across a good alternative pattern for async http with NATS other than em-http-request?
Thanks as always for making NATS available.

@derekcollison
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look to see if I can make the cluster branch work with 1.0.

Please sign in to comment.