Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long url links do not wrap text properly #1136

Closed
calculuschild opened this issue Dec 4, 2020 · 5 comments
Closed

Long url links do not wrap text properly #1136

calculuschild opened this issue Dec 4, 2020 · 5 comments
Labels
bug We say this works but it doesn't phb-style sub-epic Sub-task of an Epic

Comments

@calculuschild
Copy link
Member

calculuschild commented Dec 4, 2020

See https://homebrewery.naturalcrit.com/share/1cvV9nZNB1RF0rwy7Vp-lWLR9OJ1AmjgXWBmY6wY85Q-J

image

@calculuschild calculuschild added bug We say this works but it doesn't phb-style labels Dec 4, 2020
@ericscheid
Copy link
Collaborator

Long words, whether inside links or not, don't get wrapped by default in Chrome.

You can however add .phb { overflow-wrap: break-word; } inside a <style> block.

Here are some long words to test with

  • Pneumonoultramicroscopicsilicovolcanoconiosis
  • Hippopotomonstrosesquippedaliophobia
  • Supercalifragilisticexpialidocious
  • Pseudopseudohypoparathyroidism
  • Floccinaucinihilipilification
  • Antidisestablishmentarianism
  • Honorificabilitudinitatibus
  • Thyroparathyroidectomized
  • Dichlorodifluoromethane
  • Incomprehensibilities

(ref: https://css-tricks.com/snippets/css/prevent-long-urls-from-breaking-out-of-container/)

@calculuschild
Copy link
Member Author

Wanna make the PR for this? I'm assuming this fix would be safe for existing brews? I don't think anyone intentionally has words going off the page... right?

@ericscheid
Copy link
Collaborator

The danger here is this will make some columns longer. All it takes is for one letter currently overflowing (i.e. barely visible to casual viwer) to instead break wrap to a new line.

It would be a breaking change.

@calculuschild
Copy link
Member Author

Mmmmmmmmmm.... Good point. Ok, let's save it for v3 then.

@calculuschild
Copy link
Member Author

Added to the V3 changelog finally. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't phb-style sub-epic Sub-task of an Epic
Projects
None yet
Development

No branches or pull requests

2 participants