Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /api route for creating new brew does not validate inputs #1204

Open
AlexeySachkov opened this issue Jan 23, 2021 · 0 comments
Open

POST /api route for creating new brew does not validate inputs #1204

AlexeySachkov opened this issue Jan 23, 2021 · 0 comments

Comments

@AlexeySachkov
Copy link
Member

This is not an important issue, but I think it would be good to design this API in better way to validate all possible inputs and return meaningful errors if something is wrong.

At the moment, I've found the following:

We do not validate fields description, tags, systems, published, createdAt, updatedAt, lastViewed, views, version and it is possible to insert some custom info there through API.

We return 500 Internal Server Error if some mandatory fields like text are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant