Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character limit to Thumbnail URL #2356

Closed
calculuschild opened this issue Sep 12, 2022 · 0 comments · Fixed by #2488
Closed

Add character limit to Thumbnail URL #2356

calculuschild opened this issue Sep 12, 2022 · 0 comments · Fixed by #2488
Labels
P0 - security or data loss Possible damage to server, users, or data

Comments

@calculuschild
Copy link
Member

We've already had some people try to store whole Base64 images in the URL which massively increases storage size and bottlenecks loading and saving of brews, potentially leading to full crashes of the server. The current limit is 124 but due to the max size of Google Drive file properties (the Homebrewery will crash to an error page), but this is pretty restrictive and occurs commonly in standard URLs. Hows about... 256 characters for starters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - security or data loss Possible damage to server, users, or data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant