Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ah! I can't find a Log out button! #303

Closed
SurrealAsh opened this issue Jan 26, 2017 · 7 comments · Fixed by #2015
Closed

Ah! I can't find a Log out button! #303

SurrealAsh opened this issue Jan 26, 2017 · 7 comments · Fixed by #2015
Labels
Approved Has been discussed and an approach is agreed upon P1 - high priority Obvious bug or popular features solution found A solution exists; just needs to be applied UI/UX User Interface, user experience

Comments

@SurrealAsh
Copy link

SurrealAsh commented Jan 26, 2017

My friend logged in to my computer, and now I can't log out. Is this intentional? If not, where could I find the log out? Thanks!

@dmmagic
Copy link

dmmagic commented Jan 26, 2017

If you delete your cookies, it will log you out. Other than that, I don't see a logout button either.

@stolksdorf
Copy link
Collaborator

Yeah that was an oversight on my end. There's a logout button here. There will be a logout button on the userpage in v3.

@stolksdorf stolksdorf added the solution found A solution exists; just needs to be applied label Jan 26, 2017
@vlos
Copy link

vlos commented Jan 27, 2017

Will the login be fixed for local copies?

@stolksdorf
Copy link
Collaborator

Yup, I've build an entire self-contained login system for v3 for development/local versions of the project.

@Gazook89 Gazook89 added the UI/UX User Interface, user experience label Jul 26, 2021
@calculuschild calculuschild added the P1 - high priority Obvious bug or popular features label Dec 22, 2021
@calculuschild calculuschild added the Approved Has been discussed and an approach is agreed upon label Feb 7, 2022
@calculuschild calculuschild added this to Discussed and Approved in Issues Organizer via automation Feb 7, 2022
@calculuschild calculuschild moved this from Discussed and Approved to In progress in Issues Organizer Feb 7, 2022
@calculuschild calculuschild moved this from In progress to High Priority in Issues Organizer Feb 7, 2022
@G-Ambatte
Copy link
Collaborator

Has anyone been able to find stolksdorf's self-contained login system for local installs? Or do we just go ahead and start from scratch?

@calculuschild
Copy link
Member

calculuschild commented Feb 7, 2022

@G-Ambatte the log out button does not rely on an offline login system to work. We can literally just copy the code from the logout button from Naturalcrit.com/login. All it does is wipe the cookie that stores the current user session.

Getting the self-contained login for local installs is a separate issue, in #269, and the code for that is in Stolksdorf's old V3 branch.

@G-Ambatte
Copy link
Collaborator

G-Ambatte commented Feb 7, 2022

Recording this so it is easily found for future reference:

From stolksdorf's v3 branch:-
I believe that this the login code: https://github.com/stolksdorf/homebrewery/blob/v3/server/dev.routes.js
This seems to be where a JWT token is generated for local use, although it doesn't seem to have any authentication check. Whether there should be a password authentication required for purely local use is another question entirely.

Logout is here: https://github.com/stolksdorf/homebrewery/blob/v3/shared/homebrewery/account.actions.js
The cookies are reset for both NaturalCrit.com and local use; I'm not certain that this is desirable behaviour.

It shouldn't be difficult to wrap these into a module and only load the functions when process.env.NODE_ENV != 'production'.

Issues Organizer automation moved this from High Priority to Done Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has been discussed and an approach is agreed upon P1 - high priority Obvious bug or popular features solution found A solution exists; just needs to be applied UI/UX User Interface, user experience
Projects
Development

Successfully merging a pull request may close this issue.

7 participants