-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framed monster block background image doesn't appear in the PDF #3275
Comments
I just test with a new brew, featuring only a framed stat block, with Chrome on Mac (viewed in Preview), and had no issue. Hrm. Are you using the default PDF printer, or something else (CutePDF etc)? Is this true with a brand new brew, with no custom css? Or, can you provide the Share link to your brew that isn't working? Chrome Version 120.0.6099.234 (Official Build) (arm64) |
I can't share the brew publicly because it is a product yet to be released on the DMsGuild. I'm using the default printer (on Windows, btw). I've tested with a brand new brew, and it works. It also works by copying a single page of the brew with a stat block with the custom css. The brew is not that big (30 pages), but there's basically an image in every page along side the stat blocks. Could be some memory issue. Once I add the pages (cover page & toc + intro page) that should be before the first page with a stat block, the background disappears. If delete both pages, only the first stat block has the background, the others default to the background color. |
I've circumvented the problem by adding the background texture as a before element in the .monster.frame blocks. The code for it looks like this (for .wide blocks, it is equal except for the width, which is 102.1%).
I'm closing this issue. |
Please save a new brew in which you find this issue, and share it with us. Also, what is your OS, and your browser, and the version of both? It might also be your own CSS, if nothing else is faulty, it will be the css. |
Here's a brew with the same problem, no CSS changes from the base v3: I had a 2-page lore doc for my campaign (avernus) written in Portuguese, added two pages with the same generated stat block in each: no background when generating the PDF. However, I discovered that if I scroll down to the stat block in the print page, the background loads for that stat block (and that stat block only). Additional stat blocks only have the background color. Here's the share link: https://homebrewery.naturalcrit.com/share/MbQOA3BqiTUz Tested in both browsers below, on Windows 10: |
Looks like we have I believe the original reason we had that was that by attaching the background to the page coordinates rather than the statblock, every statblock on a page would be a "window" onto a different section of the background texture, instead of each having the same identical section of parchment. There is probably a better option to do this than "fixed". @RKuerten In the mean time you can add this code to your Style tab:
|
so the bug can't happen in a one page document, good to know. |
For #3297 , the fix should be to just remove the (Unset is only needed to overwrite an existing property, which you would need to do if trying to fix this from your brew style tab.) Just reopening this instead of making a new issue, so we have all the context. |
Created a new pull request to fix that. |
Fixed with the merge of #3330 |
Renderer
v3
Browser
Chrome
Operating System
Windows
What happened?
When generating a PDF, the .monster.frame is always generated with the background color, ignoring the background image.
I tested with different background images, with different background-blend-modes (mainly normal, lighten, darken, and multiply), the result is always the same (no background image for the monster block in the PDF).
Browser vs Generated PDF
Browsers tested:
Brave V 1.62.153 w/ Chromium 121.0.6167.85 64-bits
Chrome V 121.0.6167.86 64-bits
Code
No response
The text was updated successfully, but these errors were encountered: