text with "leading-zero" result in wrong value

[EyesOnlyNet]

Hi, i faced an issue regarding the conversion of "date" and "time" values with leading zeros.

Given:

<?xml version="1.0"?>
<date>02082017</date>

Result:

{
    "date": 2082017
}

Expected:

{
    "date": "02082017"
}

I need the original, unprocessed values of the XML. So my idea would be, to have an option like "preserveTextNodeValues": true or "convertTextNodeValues": false to skip the value conversion and keep the original string value.

[amitguptagwl]

It can be easily done. Bur unfortunately I don't have any machine now a days. So you'll have to wait for a month.

…

On 17-May-2017 10:31 PM, "Steve Reichenbach" ***@***.***> wrote: Hi, i faced an issue regarding the conversion of "date" and "time" values with leading zeros. Given: <?xml version="1.0"?> <date>02082017</date> Result: { "date": 2082017 } Expected: { "date": "02082017" } I need the original, *unprocessed* values of the XML. So my idea would be, to have an option like "preserveTextNodeValues": true or "convertTextNodeValues": false to skip the value conversion and keep the original string value. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVgKHwlfM5fd3EF-PxpCmKX95YmpQUbks5r6vajgaJpZM4Nd3ks> .

[EyesOnlyNet]

I've created a pull request for that (#11). Would be nice if you can check it. Maybe it is possible to handle that issue earlier with that.

[amitguptagwl]

Thanks a lot for your valuable time to do the changes. But there is one more task need to run ie "bundle". It'll generate the bundled js for web use in lib folder.

Can you plz update that as well? I'm sorry to be dependent.

[EyesOnlyNet]

It is done.
No sorry, if it is only that to proceed. 😃

[amitguptagwl]

I have merged the changes. And updated the version. Let me see if I can publish it to npm using my mobile. Otherwise you'll have to update it via github.

Thanks for your effort and time.

*I hope to get laptop in next 2 weeks.

[EyesOnlyNet]

Great, thank you very much.

[nidhi-tandon]

Is this issue resolved in latest npm update 2.4.3?

[amitguptagwl]

Yes. It must be. Let me know if you see any issue.

…

On 07-Jun-2017 7:55 PM, "NIDHI TANDON" ***@***.***> wrote: Is this issue resolved in latest npm update 2.4.3? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVgKEYut_2mo8hAh1FFN8owmy12HQk8ks5sBoG7gaJpZM4Nd3ks> .

[fidelsam1992]

This issue is not resolved yet ...
I tried on the latest NPM package 3.11.1
I also tried on the master branch

with this option set :
var options={
textNodeConversion:false
}

The output is still wrong

[amitguptagwl]

@fidelsam1992 This issue is very old. options name have been changed now. Can you please check README for correct option name?