Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endian issue for gzip.crc #8

Closed
jefferis opened this issue Jul 3, 2015 · 0 comments
Closed

fix endian issue for gzip.crc #8

jefferis opened this issue Jul 3, 2015 · 0 comments

Comments

@jefferis
Copy link
Collaborator

jefferis commented Jul 3, 2015

Quoth BDR

This invalidly assumes a little-endian platform: on Sparc (big-endian) it fails with

* checking tests ...
 Running ‘testthat.R’
ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
 Loading required package: nat.utils
 1. Failure (at test-gziputils.r#11): digest(,algo="crc32") and gzip.crc agree --
 crc1 not equal to crc2
 1 string mismatches:
 x[1]: "89f07f7b"
 y[1]: "7b7ff089"

But I am not sure why this has not failed previously. It looks like the problem is that gzip is always written little endian e. g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant