Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neuprint_get_meta should have more efficient handling of duplicates #92

Closed
jefferis opened this issue Mar 2, 2020 · 3 comments
Closed

neuprint_get_meta should have more efficient handling of duplicates #92

jefferis opened this issue Mar 2, 2020 · 3 comments

Comments

@jefferis
Copy link
Contributor

jefferis commented Mar 2, 2020

See approach in neuprint_get_neuron_names. Should also consider how to handle bad bodyids. It may be that we want to (optionally) return NA rows in this case.
@jefferis
Copy link
Contributor Author

jefferis commented Mar 2, 2020

Maybe we could error out for bad bodyids (e.g. 1) that don't actually exist, but propagate NAs.

@jefferis
Copy link
Contributor Author

jefferis commented Mar 2, 2020

id2bit64 will also need to be taught how to handle NAs and may need an na.rm argument.

@romainFr romainFr mentioned this issue Apr 21, 2020
Merged
@jefferis jefferis mentioned this issue Apr 25, 2020
Open
@jefferis
Copy link
Contributor Author

Closed since #113 fixes the issue in the title. For handling of NAs, see #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jefferis