Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default graphql @deprecated directive is skipped #33

Open
slavik-pastushenko opened this issue Oct 25, 2023 · 1 comment
Open

The default graphql @deprecated directive is skipped #33

slavik-pastushenko opened this issue Oct 25, 2023 · 1 comment

Comments

@slavik-pastushenko
Copy link

Hello!

It seems like there is an issue with the deprecated fields.
I am specifying a list of URLs and using graphql.IntrospectRemoteSchemas(...) to get my schema.
I realised that the behaviour of resolving deprecated fields is invalid.

My schema:

"Description"
property_a: [TypeA!] @deprecated(reason: "In favor of ...")

Expected result:

# Deprecated: In favor of ...
property_a: [TypeA!]

Actual result:

"Description"
property_a: [TypeA!]
@JohnStarich
Copy link
Member

Hey @slavik-pastushenko! Thanks for opening.

Can you share how you produced the result? Is that via introspection, and if so which tool did you use?
If you have the time, a Go test to reproduce would be very helpful in establishing a root cause and coming up with a fix.

It's worth noting some introspection tools may behave differently with respect to deprecation and descriptions. To my knowledge, gateway will keep directives as-is in the merged schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants