Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Upstream Testing #171

Merged
merged 12 commits into from Feb 7, 2023
Merged

Enable Upstream Testing #171

merged 12 commits into from Feb 7, 2023

Conversation

bryanculver
Copy link
Member

@bryanculver bryanculver commented Dec 5, 2022

Closes: #DNE

What's Changed

  • Updated Dockerfile to be compatible with upstream testing
  • Updated invoke, Dockerfile defaults which are incompatible with pyproject.toml
  • Added workflow fragment to trigger testing

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@bryanculver
Copy link
Member Author

next is expected to fail because it goes to a new major version of Nautobot so can be safely ignored for now.

tasks.py Outdated Show resolved Hide resolved
@bryanculver

This comment was marked as resolved.

@bryanculver bryanculver marked this pull request as ready for review December 6, 2022 18:42
smk4664 and others added 4 commits December 23, 2022 08:37
Nautobot minimum version was not the same across all files, updated to match.
Also disable the upstream_testing during pushes per comment.
@bryanculver
Copy link
Member Author

Tried to use poetry self update to deal with nautobot-dev containers potentially having an older version of Poetry where CI/dev might have a newer one and mint a lock file that is too new (see: https://github.com/networktocode-llc/cookiecutter-ntc/pull/276#discussion_r974383161, https://github.com/nautobot/nautobot-plugin-chatops/actions/runs/4088225247/jobs/7049757009#step:7:194).

Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bryan for fixing the CI and improving the process! Hopefully in the future we can just use poetry instead of the pip install with constraints.

@smk4664 smk4664 merged commit 87001ee into develop Feb 7, 2023
@bryanculver
Copy link
Member Author

bryanculver commented Feb 7, 2023

Thanks Bryan for fixing the CI and improving the process! Hopefully in the future we can just use poetry instead of the pip install with constraints.

Until something like this comes in: python-poetry/poetry#7051 I don't think we can go all-in for Poetry for this use case. We need to test a package within an environment of already installed packages. We don't need to be hand-crafting multiple lock files or pyproject.tomls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants