Use Graphql extra feature

[chadell]

No description provided.

[glennmatthews]

I'm missing context as to what issue 399 had to do with not enabling GraphQL, but this looks reasonable. Would it make sense to add a couple of graphql unit test cases though?

[dgarros]

I'm missing context as to what issue 399 had to do with not enabling GraphQL, but this looks reasonable. Would it make sense to add a couple of graphql unit test cases though?

@glennmatthews before #399, a GraphQL type generated by @extra_features inside a plugin wouldn't include a filterset so the workaround was to define the graphql types manually

@chadell if you are enabling @extra_features on these models, you need to also delete the corresponding GraphTypes defined in https://github.com/nautobot/nautobot-plugin-circuit-maintenance/blob/develop/nautobot_circuit_maintenance/graphql/types.py
Looks like could delete the file altogether

[chadell]

thanks @dgarros , this was actually my thought about it but was not sure.
I will try to remove the current GraphTypes if they are not needed

[chadell]

I verified that using extra_features was colliding with the craft types:

nautobot_1       | 05:11:28.367 WARNING nautobot.graphql.schema schema.py                 generate_query_mixin() :
nautobot_1       |   Unable to load schema type for the model "nautobot_circuit_maintenance.circuitmaintenance" as there is already another type registered under this name. If you are seeing this message during plugin development, check to make sure that you aren't using @extras_features("graphql") on the same model you're also defining a custom GraphQL type for.
nautobot_1       | 05:11:28.368 WARNING nautobot.graphql.schema schema.py                 generate_query_mixin() :
nautobot_1       |   Unable to load schema type for the model "nautobot_circuit_maintenance.circuitimpact" as there is already another type registered under this name. If you are seeing this message during plugin development, check to make sure that you aren't using @extras_features("graphql") on the same model you're also defining a custom GraphQL type for.

so removing non necessary code

[chadell]

@glennmatthews I've added testing for GraphQL.
As it was already approved (and only cleanup and tests have been added), I would move it forward when tests pass.