Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance Overlap Job Addition #214

Merged
merged 18 commits into from Oct 1, 2022
Merged

Maintenance Overlap Job Addition #214

merged 18 commits into from Oct 1, 2022

Conversation

jvanderaa
Copy link
Collaborator

This adds a job to search for overlapping maintenances for circuits at a site.

@jvanderaa
Copy link
Collaborator Author

Fixes #213

chadell
chadell reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first review, ping me when ready for a second pass

nautobot_circuit_maintenance/jobs/site_search.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/tests/test_jobs.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/tests/test_jobs.py Outdated Show resolved Hide resolved
nautobot_circuit_maintenance/jobs/site_search.py Show resolved Hide resolved
chadell
chadell reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

chadell
chadell reviewed Sep 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
chadell
chadell reviewed Oct 1, 2022
View reviewed changes
docs/jobs.md Outdated Show resolved Hide resolved
chadell
chadell approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit 3895356 into nautobot:develop Oct 1, 2022
@chadell chadell mentioned this pull request Oct 6, 2022
Open
itdependsnetworks pushed a commit to itdependsnetworks/nautobot-app-circuit-maintenance that referenced this pull request Apr 3, 2024
@csessh
Issue nautobot#210: Ability to parse multiple maintenance windows fro…
7fc8181 
…m Zayo maintenance notification (nautobot#214)

* Add multiple windows to Zayo maintenances

* Updated unit test cases for Zayo Parser

* Fixed CI/black job: replace single quotes with double quotes

* Fixed CI/black job: double spaces in between classes

* Fixed pydocstyle job: No blank lines allowed after function docstring

---------

Co-authored-by: mkekez <mark.kekez@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

@scetron scetron Awaiting requested review from scetron scetron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvanderaa @chadell