Add log_info for each CVE in the vulnerability job #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we look at having this as a Job option? So that the job can either be a short it just works or detailed. @qduk |
I can definitely do that. Let me make the changes and update the PR. |
|
@jvanderaa This has been updated. Thanks Josh! If there is anything else let me know. |
|
Looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a generate vulnerability job takes a long time, I wanted to be able to have some indication of the progress of the job. This gives some info without being too verbose. I did consider making this contingent on a
debuglike many jobs are but ultimately decided to put it as alog_info. I'm definitely open to either approach or no log message at all.