Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Hardware LCM to support MySQL Compliant Queries #33

Merged
merged 5 commits into from Dec 3, 2021

Conversation

josh-silvas
Copy link
Contributor

Updates Hardware LCM to support MySQL Compliant Queries (from Issue #28)
Also updates the form for hardware notices to have a similar look as the software form as to keep the plugin consistent.

Adds support for MySQL in the development environment.
Backend for invoke is determined based on the `NAUTOBOT_DB_ENGINE` variable in `development/dev.env`
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks brilliant, well done @josh5276

Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @josh5276

@brobare
Copy link

brobare commented Dec 2, 2021

@josh5276 Think this may be able to get merged soon?

@josh-silvas
Copy link
Contributor Author

Apologies for the delay @brobare. I'll get this merged and draft a new release.

@josh-silvas josh-silvas merged commit 671edeb into develop Dec 3, 2021
@bradh11 bradh11 deleted the mysql-dev-env-issue#28 branch December 7, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants