Use DjangoObject from Graphene lib. Remove GQL types for models that already use the decorator.

[progala]

• Imports DjangoObject from Graphene lib directly instead of using the Nautobot reference.
• Remove GraphQL types for models that already have GraphQL types through the @extras_features decorator.
• Add to the plugin's ready() method GraphQL override for the TaggableManager representation.
  This is copied from the core. Without it GraphQL can't auto-convert tags field on manually defined types. This worked previously because importing DjangoObject from the Nautobot modules triggerred execution of the code that does it in the core.

[glennmatthews]

I don't like duplicating convert_django_field.register code from core - what happens if core changes how it renders tags, won't this end up conflicting with it?

I thought we'd fixed this class of initialization-order issues in nautobot/nautobot#1048 - is there still a problem in 1.2.0b1?

[dgarros]

This shouldn't be required because this is already part of code https://github.com/nautobot/nautobot/blob/fcfd50e7e8aeb1d46d8fe6419d5db7e6a8f33ef3/nautobot/extras/apps.py#L25
Did you try without it ?

[progala]

It's failing in Nautobot 1.1.3 without it, for instance. It looks like when we did import with from nautobot.extras.graphql.types import DjangoObjectType the relevant code was triggered before GraphQL field conversion.

Once we changed the import to from graphene_django import DjangoObjectType we get the below error unless the code is added to __init__. Perhaps dummy import from nautobot.extras.graphql.types to trigger the execution could work as a workaround with Nautobot < 1.2.0.b1 ?

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/nautobot/core/cli.py", line 182, in <module>
    main()
  File "/usr/local/lib/python3.7/site-packages/nautobot/core/cli.py", line 62, in main
    initializer=_configure_settings,  # Called after defaults
  File "/usr/local/lib/python3.7/site-packages/nautobot/core/runner/runner.py", line 266, in run_app
    management.execute_from_command_line([runner_name, command] + command_args)
  File "/usr/local/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.7/site-packages/django/core/management/__init__.py", line 377, in execute
    django.setup()
  File "/usr/local/lib/python3.7/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/usr/local/lib/python3.7/site-packages/django/apps/registry.py", line 122, in populate
    app_config.ready()
  File "/source/nautobot_device_lifecycle_mgmt/__init__.py", line 59, in ready
    super().ready()
  File "/usr/local/lib/python3.7/site-packages/nautobot/extras/plugins/__init__.py", line 89, in ready
    graphql_types = import_object(f"{self.__module__}.{self.graphql_types}")
  File "/usr/local/lib/python3.7/site-packages/nautobot/extras/plugins/utils.py", line 44, in import_object
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/source/nautobot_device_lifecycle_mgmt/graphql/types.py", line 14, in <module>
    class ValidatedSoftwareLCMType(DjangoObjectType):
  File "/usr/local/lib/python3.7/site-packages/graphene/utils/subclass_with_meta.py", line 52, in __init_subclass__
    super_class.__init_subclass_with_meta__(**options)
  File "/usr/local/lib/python3.7/site-packages/graphene_django/types.py", line 227, in __init_subclass_with_meta__
    construct_fields(model, registry, fields, exclude, convert_choices_to_enum),
  File "/usr/local/lib/python3.7/site-packages/graphene_django/types.py", line 64, in construct_fields
    field, registry, convert_choices_to_enum=_convert_choices_to_enum
  File "/usr/local/lib/python3.7/site-packages/graphene_django/converter.py", line 113, in convert_django_field_with_choices
    converted = convert_django_field(field, registry)
  File "/usr/local/lib/python3.7/functools.py", line 840, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/usr/local/lib/python3.7/site-packages/graphene_django/converter.py", line 122, in convert_django_field
    "Don't know how to convert the Django field %s (%s)" % (field, field.__class__)
Exception: Don't know how to convert the Django field nautobot_device_lifecycle_mgmt.ValidatedSoftwareLCM.tags (<class 'taggit.managers.TaggableManager'>)

[progala]

I don't like duplicating convert_django_field.register code from core - what happens if core changes how it renders tags, won't this end up conflicting with it?

I thought we'd fixed this class of initialization-order issues in nautobot/nautobot#1048 - is there still a problem in 1.2.0b1?

Thanks @glennmatthews. Is there a way to make it work with Nautobot < 1.2.0b1? Perhaps dummy import from nautobot.extras.graphql.types to trigger the execution of the existing code?

[glennmatthews]

Dummy import is definitely worth a try.

[josh-silvas]

Looks good @progala, maybe we can merge this one since you have it functioning for both versions. Then investigate other possible solutions so that we have a working 1.2 version for now.

[progala]

Looks good @progala, maybe we can merge this one since you have it functioning for both versions. Then investigate other possible solutions so that we have a working 1.2 version for now.

I just committed an update with conditional dummy import of nautobot.extras.graphql.types and confirmed it's working for both Nautobot 1.1.3 and 1.2.0b1.

[progala]

Dummy import is definitely worth a try.

Dummy import did the trick. I got rid of the duplicated code from the core.

[josh-silvas]

LGTM