New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance plugin's reporting functionality #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work @progala @pszulczewski
@dgarros @jvanderaa @josh5276 @pszulczewski This PR is now ready for the full review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @progala!
I like the way how you generalized the part where we create charts with bar_chart_attrs
and pie_chart_attrs
.
@josh5276 @jvanderaa would you like to review this one or are we good to merge ? |
Once the conflicts are covered, good to merge. |
Yes, this is great work guys! Can't wait to take some of this framework and retrofit it into the hardware portions. :) |
I am not sure why pylint terminates with an exception? |
db7d804
to
872f5cd
Compare
Sorry I am not able to find the issue myself.
and I am able to reproduce the issue in my local dev env. Steps to reproduce:
I am bringing back the branch to the last working commit. |
@pszulczewski I've updated the lock file and now the tests are passing |
Thanks @dgarros, it looks like it was failing with nautobot core 1.1.3 and you changed it to 1.1.6 in CI. |
This PR adds reporting functionality similar to the one implemented in the Golden Configuration Plugin.
Initially we're implementing two models for recording per-device and per-inventory item validation results. These tables are populated by the corresponding jobs and need to be run manually.
Two reports are provided here, one for the Devices Validated Software and one for Inventory Validated Software.
Devices Validated Software provides bar chart showing Device Platform breakdown and Table with Device Type breakdown. Report can be filtered on Devices, Device types, Device roles, Software.
Inventory Item Validated Software provides bar chart showing Inventory Item Manufacturer breakdown and Table with Device Type Name. Report can be filtered on Inventory Items, Devices, Device types, Device roles, Software.