Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IP Range and FQDN in IPAM menu #8

Closed
dgarros opened this issue Nov 2, 2021 · 4 comments
Closed

Move IP Range and FQDN in IPAM menu #8

dgarros opened this issue Nov 2, 2021 · 4 comments
Labels
question Further information is requested type: enhancement type: housekeeping type: technical debt wontfix This will not be worked on

Comments

@dgarros
Copy link

dgarros commented Nov 2, 2021

Environment

  • Nautobot version:
  • nautobot-plugin-firewall-model version:

Proposed Functionality

As far as I understand some models introduced by this plugin are not security specific like : IPRange and FQDN as such I'm wondering if it would it make sense to move them to the IPAM menu instead ?

Thoughts ?

Use Case

User experience

@whitej6
Copy link
Contributor

whitej6 commented Nov 8, 2021

I like that IF the models get pulled into core. I think if a model comes from a plugin it should stay colocated to the plugin. I support either way, we could move the two models to core and align plugin release with a minor release of Nautobot.

@dgarros
Copy link
Author

dgarros commented Nov 8, 2021

It's an interesting question that we should clarify internally

I'm of the opinion that a user shouldn't have to know if a feature is coming from a plugin or not, that's too much complexity to expose to the end users.
As such I think it's best to have the menu organized per theme Device / Routing / Security / Ipam etc ... and a plugin should insert its menu items where ever it make the most sense.

Would love to hear more feedback on this one ? @jedelman8 @itdependsnetworks @mzbroch @chadell

@whitej6
Copy link
Contributor

whitej6 commented Nov 9, 2021

Only argument for keeping in the plugin nac menu i have is as of now they aren't full featured ipam objects and to me may confuse a user where it's coming from.

Maybe denote with a submenu of the plugin it's coming from as a compromise?

Just thinking from a consumer nondev perspective, find screenshots of additional models in ipam but not having that plugin installed.

@whitej6
Copy link
Contributor

whitej6 commented Jul 7, 2022

Marking as won't do to avoid confusion. Recommend to revisit IF iprange is pulled into core

@whitej6 whitej6 closed this as completed Jul 7, 2022
@whitej6 whitej6 added the wontfix This will not be worked on label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested type: enhancement type: housekeeping type: technical debt wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants