Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer DynamicModelChoiceField and DynamicModelMultipleChoiceField #9

Closed
itdependsnetworks opened this issue Nov 3, 2021 · 3 comments
Labels
roadmap: near term status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement

Comments

@itdependsnetworks
Copy link
Contributor

Environment

  • Nautobot version: 1.1
  • nautobot-plugin-firewall-model version: 1.0

Proposed Functionality

Review each dropdown and prefer the DynamicModelChoiceField and DynamicModelMultipleChoiceField. These will soon enough become large dropdowns and the type ahead will be required.

image

Use Case

Type ahead on larger models.

@whitej6
Copy link
Contributor

whitej6 commented Nov 8, 2021

Accepted, forgot to do this.

@whitej6 whitej6 added status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement roadmap: near term labels Nov 8, 2021
@whitej6
Copy link
Contributor

whitej6 commented Nov 21, 2021

Solved via #16

@whitej6 whitej6 closed this as completed Nov 21, 2021
@itdependsnetworks
Copy link
Contributor Author

I think there is some confusion, as an example, look at the following examples:

  • It is not clear what the context is per interface
    image

  • I think you can use DynamicModelMultipleChoiceField.
    image

  • Which is the 10.0.0.0/8 object I want here? From one perspective, it is still the same IP, but in real life, the IP can change for one, but stay the same for the other.
    image

Basically, anywhere where there can be dozens/hundreds of attributes, it is difficult without DynamicModelChoiceField and just to review each form to ensure it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap: near term status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants